Raising TypeError on invalid window when using .rolling #12669 #12718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1354,6 +1354,8 @@ def _get_center_of_mass(com, span, halflife, alpha): | |||
|
|
|||
|
|
|||
| def _offset(window, center): | |||
| if com.is_float(window): | |||
| raise TypeError("Window should be of type Integer, given Float") | |||
There was a problem hiding this comment.
It would be better to use if not com.is_integer(window): raise TypeError but that will clearly need to happen at a another point in the code, because at this point we accept arrays (see line below)
There was a problem hiding this comment.
this needs to happen in the _Rolling constructor. if window is not None then it can be tested for being an integer (or raise TypeError)
4 tasks
|
competing PR is #12714 |
jreback
added
Reshaping
|
can you rebase/update according to comments |
|
can you rebase / update |
|
superseded by #13002 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diff